Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: claim NODE_MODULE_VERSION=80 for Electron 9 #30052

Closed
wants to merge 1 commit into from

Conversation

MarshallOfSound
Copy link
Member

As in title, just claiming our next number

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 21, 2019
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please coordinate with @targos as #30020 is also claiming 80.

@MarshallOfSound
Copy link
Member Author

@targos Happy to take whichever number but I feel as though this PR is gonna land first. Just lemme know which number you're ok with 👍

@targos
Copy link
Member

targos commented Oct 22, 2019

#30020 is going to land much later, you can have 80.

@targos
Copy link
Member

targos commented Oct 24, 2019

targos pushed a commit that referenced this pull request Oct 27, 2019
PR-URL: #30052
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Oct 27, 2019

Landed in 3a90fcf

@targos targos closed this Oct 27, 2019
targos pushed a commit that referenced this pull request Oct 28, 2019
PR-URL: #30052
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 5, 2019
@pmahend1
Copy link

So what does NODE_MODULE_VERSION corresponds to ? I used NodeJs 13.1.0 for building electron-edge-js , and it says that is NODE_MODULE_VERSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants